[HOLD for payment 2023-02-18] [$2000] [Image][Feature] Show a user friendly name for the attachment images for take pictures option - reported by @parasharrajat

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Problem:

IMO, Showing vague names or using terms like temp or image_picker in the name is not good for brand value. I have seen many users making fuss out of such things on the internet which could be bad for branch.

Solution:

Choose a proper name for the image or don't the show the name when image is taken directly from the camera.

Action Performed:

1. Open any chat.
2. Click add attachment option from the ➕ icon.
3. Choose 📷 Take Photo.
4. Click a photo.
5. On the Preview page header check the name of the image.

Expected Result:

Show a user friendly name for the attachment images for take pictures option

The expected result was updated after this conversation

New expected result: The attachment name shouldn't be visible when there is a preview

Actual Result:

generic image name displayed

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.1-0
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1661616286179839

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018f82e1a898c313a5
• Upwork Job ID: 1615996670996901888
• Last Price Increase: 2023-01-26

[melvin-bot]

Triggered auto assignment to @sakluger (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[sakluger]

I agree that we don't need to show a temp filename when sending an attachment that is an image from your phone. I would think we can just remove the filename when attaching from the phone.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[melvin-bot]

Current assignee @Julesssss is eligible for the External assigner, not assigning anyone new.

[trjExpensify]

Choose a proper name for the image or don't the show the name when image is taken directly from the camera.

The solution is ambiguous right now, I don't think this is ready to go external until we decide on a direction. My two cents..

• I don't like the idea of not showing any name at all, because it lacks consistency with images uploaded from file that do display a name.

• In another issue, there's discussion about the need for uniqueness in the attachment name, so choosing something static like Picture from camera.jpg will be problematic won't it, unless we add a timestamp to it? I.e Picture from camera <timestamp>.jpg.

Lastly, this feels like it should be tracked with this issue for image related feature requests and improvements. @roryabraham would you agree, and therefore should we place this particular issue on hold?

[Julesssss]

Ah, I looked at the Slack convo this morning and it looked like we had a solution that uses the read filename instead of a temp one (which i assumed we were generating).

Lastly, this feels like it should be tracked with #10894 for image related feature requests

Yeah, I agree with this. Switching to hold for now 👍

[trjExpensify]

Sounds like a great choice!

Edit: Taking this issue off hold.

[thesahindia]

@Puneet-here's proposal looks good to me @aldo-expensify.

C+ reviewed 🎀👀🎀

[Puneet-here]

I think we should confirm first if are going to keep the file names for pdf files If we want we can use Str.isPDF to only show the file name for pdf

[aldo-expensify]

I think we should confirm first if are going to keep the file names for pdf files If we want we can use Str.isPDF to only show the file name for pdf

Hmm, I personally don't see why we would have an exception for PDFs, but maybe I'm missing something you are thinking :P. You should bring this question to the slack thread if you want to confirm.

[Puneet-here]

I was thinking file names for pdf files can be useful when user has similar pdf files in chat history and trying to find some pdf. They could easily check the file name instead of reading some text in the pdf file. But as I am writing this I think that's an edge case so never mind.

[aldo-expensify]

I had the same thought for images when you have similar images, but agree with doing nothing because I also see it as an edge case.

[Puneet-here]

@aldo-expensify, I have proposed a solution here. @thesahindia has approved, It just needs your approval. Please check when you have time.

[aldo-expensify]

Yes, lets go with #11085 (comment)

Regarding the platforms, I would go with consistency and hide the filename for all platforms.

[MelvinBot]

📣 @Puneet-here You have been assigned to this job by @aldo-expensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Puneet-here]

@thesahindia, PR is ready for review.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• remove file name from attachment modal #14962

If no regressions arise, payment will be issued on 2023-02-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[trjExpensify]

Alrighty, payments are due. I've sent the following offers:

@Puneet-here $3,000 for the fix and merge within 3 days
@thesahindia $3,000 for the review and merge within 3 days
@parasharrajat $250 for the bug report.

Please accept or let me know if that isn't accurate!

[trjExpensify]

@thesahindia - settled up!

[Puneet-here]

Accepted!

[trjExpensify]

@Puneet-here @parasharrajat - settled up! 🎉