Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use model fit returned by the Sherpa fit instead of recalculating it manually #36

Open
ivalaginja opened this issue Jun 17, 2019 · 0 comments

Comments

@ivalaginja
Copy link
Collaborator

ivalaginja commented Jun 17, 2019

After we run the second fit with Sherpa, we currently recalculate the fitted model (fit_model) manually, instead of reading it directly from the Sherpa objects. We need to figure out how to do this directly with Sherpa.

I believe that all we have to do is

fit_model = tdata.eval_model(tmodel)

but when I compare this array to the result of our manually calculated fit_model array, there is a difference in numerical accuracy, with the manual one seeming more accurate. We have to check why that is and whether we can change that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant