Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.9计划 #137

Closed
3 of 6 tasks
Executor-Cheng opened this issue Sep 11, 2022 · 2 comments · Fixed by #138
Closed
3 of 6 tasks

2.1.9计划 #137

Executor-Cheng opened this issue Sep 11, 2022 · 2 comments · Fixed by #138
Labels
documentation Improvements or additions to documentation enhancement New feature or request working The developer is working on this issue/pr.

Comments

@Executor-Cheng
Copy link
Owner

Executor-Cheng commented Sep 11, 2022

感谢 @Cyl18批评和意见

  • 异步等待时使用 ConfigureAwait(bool)
  • 提供可在 LinuxArm 环境下使用的 NativeAssets: Mirai-CSharp.NativeAssets.LinuxArm
  • 再次简化文档
  • 允许配置 MiraiHttpSessionOptions.BaseUrl 为 https
  • 支持仅使用 mirai-api-http 下的 HttpAdapter / WsAdapter, 或者二者兼用
  • 更改 Mirai-CSharp基础项目下的命名, 在其后全部添加 Base 以便区分基于基础框架还是基于实现框架 (由于是破坏性更改,暂时延迟)
@Cyl18
Copy link

Cyl18 commented Sep 11, 2022

很不好意思没有主动反馈这些问题而是在那里闷着说

关于 https 的问题

image
我以为我给 Mirai-CSharp 发了,但是没有...大概是因为我觉得TA们的态度都不太欢迎 https, 就没给你发了,主要是我个人要把 bot 挂在公网有需求

关于 native 问题

建议弄成可选依赖?

关于 ConfigureAwait

我发过 #51

关于库太复杂的问题

我是比较喜欢 Mirai-CSharp v1 式的 API,但是就是现在文档看着有点乱,改改大概也能降低学习成本

关于 HttpAdapter 问题

这个其实是 mirai-api-http 本身的问题 我自己去 TA 们那边 发过 issue, 就是 ws 不能单独用谁都很烦


总之还是非常感谢你能抽时间解决这些问题的❤

@Executor-Cheng Executor-Cheng added documentation Improvements or additions to documentation enhancement New feature or request working The developer is working on this issue/pr. labels Sep 11, 2022
@Executor-Cheng
Copy link
Owner Author

哪里,我才是要感到不好意思的那一个,老鸽子了导致文档一直没能写得很好
native作为可选是个不错的选择
为啥我要v1的api的原因是因为往后再加event会使得一个类下边的成员太多,导致其体积太大,也不易于维护。用到DI也是因为我觉得解耦是很有必要去做的。如果还是按照v1,那在接受消息的时候就势必要根据cmd进行体积超长的switch,同样会降低可维护性
HttpAdapter这个好说,做个轮询的就行了
晚上泡杯咖啡开工,我感觉我已经亚健康了,动不动就觉得没精神然后就咕了,你也加油呀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request working The developer is working on this issue/pr.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants