#5 Fix Separate Values button fails on column with all zero strings in C# version

tduguid · tduguid · commit 0fae55164c8d · 2018-01-14T11:23:41.000+11:00
diff --git a/CS/Scripts/Ribbon.cs b/CS/Scripts/Ribbon.cs
@@ -923,9 +923,9 @@ public void SeparateValues()
 
                 for (int i = 1; i <= m + 1; i++) // by row
                 {
-                    string cellValue = tbl.Range.Cells[i, columnIndex].Value2.ToString();
-                    if (string.IsNullOrEmpty(cellValue) == false)
+                    if (tbl.Range.Cells[i, columnIndex].Value2 != null)
                     {
+                        string cellValue = tbl.Range.Cells[i, columnIndex].Value2.ToString();
                         string[] metadata = cellValue.Split(Properties.Settings.Default.Table_ColumnSeparateValuesDelimiter);
                         int countValues = metadata.Length - 1;
                         if (countValues > 0)

Original file line number	Diff line number	Diff line change
`@@ -923,9 +923,9 @@ public void SeparateValues()`
`923`	`923`
`924`	`924`	`for (int i = 1; i <= m + 1; i++) // by row`
`925`	`925`	`{`
`926`		`- string cellValue = tbl.Range.Cells[i, columnIndex].Value2.ToString();`
`927`		`- if (string.IsNullOrEmpty(cellValue) == false)`
	`926`	`+ if (tbl.Range.Cells[i, columnIndex].Value2 != null)`
`928`	`927`	`{`
	`928`	`+ string cellValue = tbl.Range.Cells[i, columnIndex].Value2.ToString();`
`929`	`929`	`string[] metadata = cellValue.Split(Properties.Settings.Default.Table_ColumnSeparateValuesDelimiter);`
`930`	`930`	`int countValues = metadata.Length - 1;`
`931`	`931`	`if (countValues > 0)`