Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kotlin-result library to v2 #5

Open
vewert opened this issue Apr 30, 2024 · 1 comment
Open

Update kotlin-result library to v2 #5

vewert opened this issue Apr 30, 2024 · 1 comment
Assignees
Labels
state: deferred An issue that should be re-visited in the future type: enhancement New feature or request

Comments

@vewert
Copy link
Member

vewert commented Apr 30, 2024

Starting with v2 the kotlin-result library models its Result type as an inline value class, in order to reduce overhead,

see: https://github.com/michaelbull/kotlin-result
and: https://github.com/michaelbull/kotlin-result/wiki/Overhead

This update, however, makes some breaking changes to API.

We should update our library to be able to use this new version.

@vewert vewert self-assigned this Apr 30, 2024
@vewert vewert added the type: enhancement New feature or request label Apr 30, 2024
@vewert
Copy link
Member Author

vewert commented May 6, 2024

It looks like the new inlined Result type, makes it more difficult to interop with Java (and other jvm languages), see: michaelbull/kotlin-result#101.

Will hold off on upgrading to v2 for a bit.

@vewert vewert added the state: deferred An issue that should be re-visited in the future label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: deferred An issue that should be re-visited in the future type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant