[WIP] Исправление замечаний сонара и рефакторинг #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukon39
changed the title
EvilBeaver
approved these changes
Oct 1, 2023
| @@ -20,7 +20,7 @@ | |||
| namespace OneScript.StandardLibrary.XDTO | |||
| { | |||
| [ContextClass("СериализаторXDTO", "XDTOSerializer")] | |||
| public class XDTOSerializer : AutoContext<XDTOSerializer> | |||
| public sealed class XDTOSerializer : AutoContext<XDTOSerializer> | |||
There was a problem hiding this comment.
А чего ради тут sealed? Чем сонар это мотивирует?
There was a problem hiding this comment.
Наверное тем же, зачем в java сонар рекомендует ставить final. Вырубил в бсл лс эту проверку нахер х)
There was a problem hiding this comment.
Типа если класс поддерживает расширение, то это должно быть прописано с умом, а так - the most restrictive action по Все поля
There was a problem hiding this comment.
в дотнете расширяемость метода по умолчанию отсутствует (в отличие от Явы), поэтому ставить финал, чтобы кто-то не перекрыл неконтролируемо твой метод не надо, ты и так в базовом классе явно определяешь, что у тебя переопределяемое
|
@yukon39 стоит WIP. Еще нельзя вливать? |
|
Если замечаний нет, то вливайте |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1344