Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Allow manual ack and nack to take multiple messages #158

Open
ghostbuster91 opened this issue Jul 30, 2020 · 0 comments
Open

Allow manual ack and nack to take multiple messages #158

ghostbuster91 opened this issue Jul 30, 2020 · 0 comments

Comments

@ghostbuster91
Copy link

Currently messages for manual ack and nack in PersistentSubscriptionActor are defined as follows:

  final case class ManualAck(eventId: Uuid)
  final case class ManualNak(eventId: Uuid)

While the underlying api allows to pass there multiple events id:

    case Event(PSA.ManualAck(eventId), details: PSA.SubscriptionDetails) =>
      toConnection(Ack(details.subscriptionId, eventId :: Nil))
      stay
    case Event(PSA.ManualNak(eventId), details: PSA.SubscriptionDetails) =>
      toConnection(Nak(details.subscriptionId, List(eventId), Retry, None))
      stay
  }

Is there any valid reason why options to pass lists isn't exposed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant