Skip to content

Commit faeed75

Browse files
authored
CI: Update sizes message (mrdoob#25826)
* Trigger report on utils/build * Remove custom three.module.min.js build * Update filesize message on PR * Update build command
1 parent 7de573a commit faeed75

File tree

4 files changed

+29
-24
lines changed

4 files changed

+29
-24
lines changed

.github/workflows/read-size.yml

+5-4
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ on:
55
paths:
66
- 'src/**'
77
- 'package.json'
8+
- 'utils/build/**'
89

910
# This workflow runs in a read-only environment. We can safely checkout
1011
# the PR code here.
@@ -28,15 +29,15 @@ jobs:
2829
- name: Install dependencies
2930
run: npm ci
3031
- name: Build
31-
run: npm run build-module
32+
run: npm run build
3233
- name: === Test tree-shaking ===
3334
run: npm run test-treeshake
3435
- name: Read bundle sizes
3536
id: read-size
3637
run: |
37-
FILESIZE=$(stat --format=%s test/treeshake/three.module.min.js)
38-
gzip -k test/treeshake/three.module.min.js
39-
FILESIZE_GZIP=$(stat --format=%s test/treeshake/three.module.min.js.gz)
38+
FILESIZE=$(stat --format=%s build/three.module.min.js)
39+
gzip -k build/three.module.min.js
40+
FILESIZE_GZIP=$(stat --format=%s build/three.module.min.js.gz)
4041
TREESHAKEN=$(stat --format=%s test/treeshake/index.bundle.min.js)
4142
gzip -k test/treeshake/index.bundle.min.js
4243
TREESHAKEN_GZIP=$(stat --format=%s test/treeshake/index.bundle.min.js.gz)

.github/workflows/report-size.yml

+24-6
Original file line numberDiff line numberDiff line change
@@ -65,21 +65,29 @@ jobs:
6565
- name: Install dependencies
6666
run: npm ci
6767
- name: Build
68-
run: npm run build-module
68+
run: npm run build
6969
- name: === Test tree-shaking ===
7070
run: npm run test-treeshake
7171
- name: Read sizes
7272
id: read-size
7373
run: |
74-
FILESIZE_BASE=$(stat --format=%s test/treeshake/three.module.min.js)
74+
FILESIZE_BASE=$(stat --format=%s build/three.module.min.js)
75+
gzip -k build/three.module.min.js
76+
FILESIZE_BASE_GZIP=$(stat --format=%s build/three.module.min.js.gz)
7577
TREESHAKEN_BASE=$(stat --format=%s test/treeshake/index.bundle.min.js)
78+
gzip -k test/treeshake/index.bundle.min.js
79+
TREESHAKEN_BASE_GZIP=$(stat --format=%s test/treeshake/index.bundle.min.js.gz)
7680
7781
# log to console
7882
echo "FILESIZE_BASE=$FILESIZE_BASE"
83+
echo "FILESIZE_BASE_GZIP=$FILESIZE_BASE_GZIP"
7984
echo "TREESHAKEN_BASE=$TREESHAKEN_BASE"
85+
echo "TREESHAKEN_BASE_GZIP=$TREESHAKEN_BASE_GZIP"
8086
8187
echo "FILESIZE_BASE=$FILESIZE_BASE" >> $GITHUB_OUTPUT
88+
echo "FILESIZE_BASE_GZIP=$FILESIZE_BASE_GZIP" >> $GITHUB_OUTPUT
8289
echo "TREESHAKEN_BASE=$TREESHAKEN_BASE" >> $GITHUB_OUTPUT
90+
echo "TREESHAKEN_BASE_GZIP=$TREESHAKEN_BASE_GZIP" >> $GITHUB_OUTPUT
8391
8492
- name: Format sizes
8593
id: format
@@ -89,22 +97,32 @@ jobs:
8997
FILESIZE: ${{ fromJSON(steps.download-artifact.outputs.result).filesize }}
9098
FILESIZE_GZIP: ${{ fromJSON(steps.download-artifact.outputs.result).gzip }}
9199
FILESIZE_BASE: ${{ steps.read-size.outputs.FILESIZE_BASE }}
100+
FILESIZE_BASE_GZIP: ${{ steps.read-size.outputs.FILESIZE_BASE_GZIP }}
92101
TREESHAKEN: ${{ fromJSON(steps.download-artifact.outputs.result).treeshaken }}
93102
TREESHAKEN_GZIP: ${{ fromJSON(steps.download-artifact.outputs.result).treeshakenGzip }}
94103
TREESHAKEN_BASE: ${{ steps.read-size.outputs.TREESHAKEN_BASE }}
104+
TREESHAKEN_BASE_GZIP: ${{ steps.read-size.outputs.TREESHAKEN_BASE_GZIP }}
95105
run: |
96106
FILESIZE_FORM=$(node ./test/treeshake/utils/format-size.js "$FILESIZE")
97107
FILESIZE_GZIP_FORM=$(node ./test/treeshake/utils/format-size.js "$FILESIZE_GZIP")
108+
FILESIZE_BASE_FORM=$(node ./test/treeshake/utils/format-size.js "$FILESIZE_BASE")
109+
FILESIZE_BASE_GZIP_FORM=$(node ./test/treeshake/utils/format-size.js "$FILESIZE_BASE_GZIP")
98110
FILESIZE_DIFF=$(node ./test/treeshake/utils/format-diff.js "$FILESIZE" "$FILESIZE_BASE")
99111
TREESHAKEN_FORM=$(node ./test/treeshake/utils/format-size.js "$TREESHAKEN")
100112
TREESHAKEN_GZIP_FORM=$(node ./test/treeshake/utils/format-size.js "$TREESHAKEN_GZIP")
113+
TREESHAKEN_BASE_FORM=$(node ./test/treeshake/utils/format-size.js "$TREESHAKEN_BASE")
114+
TREESHAKEN_BASE_GZIP_FORM=$(node ./test/treeshake/utils/format-size.js "$TREESHAKEN_BASE_GZIP")
101115
TREESHAKEN_DIFF=$(node ./test/treeshake/utils/format-diff.js "$TREESHAKEN" "$TREESHAKEN_BASE")
102116
103117
echo "FILESIZE=$FILESIZE_FORM" >> $GITHUB_OUTPUT
104118
echo "FILESIZE_GZIP=$FILESIZE_GZIP_FORM" >> $GITHUB_OUTPUT
119+
echo "FILESIZE_BASE_=$FILESIZE_BASE_FORM" >> $GITHUB_OUTPUT
120+
echo "FILESIZE_BASE_GZIP=$FILESIZE_BASE_GZIP_FORM" >> $GITHUB_OUTPUT
105121
echo "FILESIZE_DIFF=$FILESIZE_DIFF" >> $GITHUB_OUTPUT
106122
echo "TREESHAKEN=$TREESHAKEN_FORM" >> $GITHUB_OUTPUT
107123
echo "TREESHAKEN_GZIP=$TREESHAKEN_GZIP_FORM" >> $GITHUB_OUTPUT
124+
echo "TREESHAKEN_BASE=$TREESHAKEN_BASE_FORM" >> $GITHUB_OUTPUT
125+
echo "TREESHAKEN_BASE_GZIP=$TREESHAKEN_BASE_GZIP_FORM" >> $GITHUB_OUTPUT
108126
echo "TREESHAKEN_DIFF=$TREESHAKEN_DIFF" >> $GITHUB_OUTPUT
109127
110128
- name: Find existing comment
@@ -125,14 +143,14 @@ jobs:
125143
126144
_Full ESM build, minified and gzipped._
127145
128-
| Filesize | Gzipped | Diff from `${{ github.ref_name }}` |
146+
| Filesize `${{ github.ref_name }}` | Filesize PR | Diff |
129147
|----------|---------|------|
130-
| ${{ steps.format.outputs.FILESIZE }} | ${{ steps.format.outputs.FILESIZE_GZIP }} | ${{ steps.format.outputs.FILESIZE_DIFF }} |
148+
| ${{ steps.format.outputs.FILESIZE_BASE }} (${{ steps.format.outputs.FILESIZE_BASE_GZIP }}) | ${{ steps.format.outputs.FILESIZE }} (${{ steps.format.outputs.FILESIZE_GZIP }}) | ${{ steps.format.outputs.FILESIZE_DIFF }} |
131149
132150
### 🌳 Bundle size after tree-shaking
133151
134152
_Minimal build including a renderer, camera, empty scene, and dependencies._
135153
136-
| Filesize | Gzipped | Diff from `${{ github.ref_name }}` |
154+
| Filesize `${{ github.ref_name }}` | Filesize PR | Diff |
137155
|----------|---------|------|
138-
| ${{ steps.format.outputs.TREESHAKEN }} | ${{ steps.format.outputs.TREESHAKEN_GZIP }} | ${{ steps.format.outputs.TREESHAKEN_DIFF }} |
156+
| ${{ steps.format.outputs.TREESHAKEN_BASE }} (${{ steps.format.outputs.TREESHAKEN_BASE_GZIP }}) | ${{ steps.format.outputs.TREESHAKEN }} (${{ steps.format.outputs.TREESHAKEN_GZIP }}) | ${{ steps.format.outputs.TREESHAKEN_DIFF }} |

.gitignore

-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ test/unit/build
1111
test/treeshake/index.bundle.js
1212
test/treeshake/index.bundle.min.js
1313
test/treeshake/index-src.bundle.min.js
14-
test/treeshake/three.module.min.js
1514
test/treeshake/stats.html
1615
test/e2e/chromium
1716
test/e2e/output-screenshots

test/rollup.treeshake.config.js

-13
Original file line numberDiff line numberDiff line change
@@ -69,17 +69,4 @@ export default [
6969
}
7070
]
7171
},
72-
// esm bundle size minified, used in read-size.yml
73-
{
74-
input: 'build/three.module.js',
75-
plugins: [
76-
terser(),
77-
],
78-
output: [
79-
{
80-
format: 'esm',
81-
file: 'test/treeshake/three.module.min.js'
82-
}
83-
]
84-
},
8572
];

0 commit comments

Comments
 (0)