Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If "respawn-at-home-bed" and "respawn-at-home" are set to true in the EssentialsX config, "respawn-at-anchor" is ultimately ignored. #5824

Open
gibsonpil opened this issue Jun 7, 2024 · 0 comments · May be fixed by #5825
Labels
bug: unconfirmed Potential bugs that need replicating to verify.

Comments

@gibsonpil
Copy link

gibsonpil commented Jun 7, 2024

Type of bug

Other unexpected behaviour

/ess dump all output

N/A

Error log (if applicable)

No response

Bug description

The bugged code is in the onPlayerRespawn method in EssentialsSpawnPlayerListener.

The respawn-at-anchor option works by simply returning without modifying the spawn location if the default Minecraft spawn is a respawn anchor and the respawn-at-anchor option is set to true. However, if it isn't set to true, while respawn-at-home and respawn-at-home-bed are, the respawn point will ultimately get set to the value of the method getBedSpawnLocation() in the Spigot API. In spite of this method's name, it doesn't just get bed spawn locations, but also gets the location of respawn anchors.

As a result, if a player's respawn point is set to a respawn anchor and respawn-at-home-bed and respawn-at-home are true, the player will still respawn at the respawn anchor.

Steps to reproduce

  1. Set respawn-at-anchor to false, and respawn-at-home and respawn-at-home-bed to true in the Essentials configuration.
  2. Mark your spawn at a respawn anchor.
  3. Try respawning.

Expected behaviour

Players should be unable to respawn at respawn anchors unless respawn-at-anchor is true.

Actual behaviour

Players can respawn at respawn anchors if respawn-at-home-bed and respawn-at-home are set to true.

Additional Information

No response

@gibsonpil gibsonpil added the bug: unconfirmed Potential bugs that need replicating to verify. label Jun 7, 2024
gibsonpil added a commit to gibsonpil/Essentials that referenced this issue Jun 7, 2024
@gibsonpil gibsonpil linked a pull request Jun 7, 2024 that will close this issue
3 tasks
gibsonpil added a commit to gibsonpil/Essentials that referenced this issue Jul 20, 2024
gibsonpil added a commit to gibsonpil/Essentials that referenced this issue Jul 23, 2024
gibsonpil added a commit to gibsonpil/Essentials that referenced this issue Jul 23, 2024
gibsonpil added a commit to gibsonpil/Essentials that referenced this issue Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: unconfirmed Potential bugs that need replicating to verify.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant