Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for placing items in specific slots (offhand, armor, etc) #5535

Open
mataaj opened this issue Oct 8, 2023 · 5 comments · May be fixed by #5794
Open

Add an option for placing items in specific slots (offhand, armor, etc) #5535

mataaj opened this issue Oct 8, 2023 · 5 comments · May be fixed by #5794
Labels
type: enhancement Features and feature requests.

Comments

@mataaj
Copy link

mataaj commented Oct 8, 2023

Feature description

Currently, when you put an item in your offhand slot, create a kit in-game using /kitcreate and then run /kit <kit> to recieve the kit, the item does not appear in your offhand slot, but in the first available slot instead. Im suggesting to add a toggleable option that, when enabled, would automatically put the item in the offhand slot (as long as the item was in offhand slot when creating the kit of course).

How the feature is useful

The feature could be quite useful for kits containing, for example, shields. As most players would probably want to put them in their offhand slot, I think they would appreciate receiving the kit in this state and not having to move their shield there every time they get the kit.

@mataaj mataaj added the type: enhancement Features and feature requests. label Oct 8, 2023
@baailey
Copy link

baailey commented Oct 8, 2023

Have you tried this with the config option use-nbt-serialization-in-createkit set to true?

@mataaj
Copy link
Author

mataaj commented Oct 8, 2023

Yes, is that supposed to have any effect on this? Because for me, it does not.

@baailey
Copy link

baailey commented Oct 8, 2023

Not sure, I assumed it would've but seems not

@pop4959 pop4959 changed the title Add kits-auto-offhand option to kits Add an option for placing items in specific slots (offhand, armor, etc) Dec 10, 2023
@pop4959
Copy link
Member

pop4959 commented Dec 10, 2023

Rather than auto equip certain items into the offhand slot it would make more sense to allow specific items into separate slots with /kit. This would solve the issue of equipping correctly as well without making assumptions about what items to auto equip (for example, auto equipping shields when someone else may want to auto equip a torch instead).

@Evidentsinger14
Copy link
Member

adding onto this, a potential idea of formatting the kits.yml to add this could be as such:

kits:
  a:
    delay: 1
    items:
    - diamond_chestplate 1
    equipment:
      helmet: diamond_helmet 1 name:helmet
      chestplate: diamond_chestplate 1 name:chestplate
      leggings: diamond_leggings 1 name:leggings
      boots: diamond_boots 1 name:boots
      offhand: shield name:shield

@TiagoFar78 TiagoFar78 linked a pull request May 7, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Features and feature requests.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants