Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose Response Headers on ArcgisError object for status != 200 #1181

Open
efbenson opened this issue Nov 8, 2024 · 2 comments
Open

Expose Response Headers on ArcgisError object for status != 200 #1181

efbenson opened this issue Nov 8, 2024 · 2 comments

Comments

@efbenson
Copy link

efbenson commented Nov 8, 2024

Describe the problem

We had a support request with AGOL and they need the response headers, there is no way to get them from this package without patching the module (which we are attempting) When a status code 500/503 (non 200) error is returned the response headers are not exposed via the error object.

Describe the proposed solution

We are seeing if this will work (in my simulations it appeared to). Tweaking this code here seemed to do it.

https://github.com/Esri/arcgis-rest-js/blob/main/packages/arcgis-rest-request/src/request.ts#L424

            const { status, statusText, headers } = response;
            const { message, details } = jsonError.error;
            const formattedMessage = `${message}. ${
              details ? details.join(" ") : ""
            }`.trim();

            throw new ArcGISRequestError(
              formattedMessage,
              `HTTP ${status} ${statusText}`,
              {body: jsonError, headers: [...headers]},
              url,
              options
            );
          })

Alternatives considered

No response

Additional Information

No response

@gavinr-maps
Copy link
Contributor

@efbenson thank you for logging this issue. This request seems reasonable to me. @patrickarlt @dbouwman do you have any thoughts on this request? Just to be clear, the proposed change is to change/add this code:

image
... at this location: https://github.com/Esri/arcgis-rest-js/blob/main/packages/arcgis-rest-request/src/request.ts#L424

@patrickarlt
Copy link
Contributor

This looks good do me if someone wants to do a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants