-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Swift 4.2 #494
Comments
thx please pod install 4.2 Lib! |
The official effort to update to swift 4.2 is now underway : #496 which also includes the old PRs that attempt to migrate it. Please review the changes. Sorry for the delay. I had some issues migrating to later versions of XCodes, but that is now fixed, so you can expect faster response cycles from me on version updates. Also @goktugyil I would need your final sign off before merging this. |
Sure, ping me when it's complete |
Any idea when it will be upgraded into swift 4.2. @Khalian any update from your side? |
@goktugyil I got the Ios stuff to build, but not the mac and tvos targets, and I cannot reproduce it on my local environment. Can you take a look? #496. |
@goktugyil referencing https://travis-ci.org/goktugyil/EZSwiftExtensions/builds/453835156?utm_source=github_status&utm_medium=notification.
There is a whole bunch of UIKit naming changes crap that is a part of swift 4.2 for some reason. This is weird because.
I really am not an expert with anything related with UIKit and this is beyond my expertise (particularly because of the fact that I might some cause some sort of regression, we dont have particularly good unit test overage on the non Foundation classes). ANY HELP FROM ANYONE ON THIS BRANCH WOULD BE APPRECIATED RIGHT NOW. You would think that Swift and Apple would care for backwards compatibility on all its platform, but whoever designs these APIs appear to be horribly brain damaged. |
@Khalian Update the .swift-version file to 4.2 should fix those pod lint errors, just tried on my repo. |
@isimple4 Definitely helped but theres a new issue now pod lib lint I will take a look at this new nonsense tomorrow. |
@Khalian There are some issues still around after Xcode 10. Check CocoaPods/CocoaPods#8116 and CocoaPods/CocoaPods#8125 for more information. |
Also this Touching EZSwiftExtensionsTest.xctest (in target: EZSwiftExtensionsTests-tvOS) |
That might be an issue of Travis when simulator was interrupted before starting tests. |
@isimple4 Neither can I. And retries do not seem to help. I raised a forum issue on the travis community forum for guidance. https://travis-ci.community/t/cant-run-unit-tests-on-swift-4-2-xcode-10/848. Maybe we can ask for more powerful travis workers or something like that. |
@Khalian There is an issue travis-ci/travis-ci#6675 discussing about it for couple of years but leaving no official solution. IMHO we could ship it after fixing pod warnings since everything looks locally good to go. |
any update on this? |
how to work on swift4.2 |
An update for 5 is coming: #501 To work on swift4.2 you can change the version of your pod to 3. You can have separate swift versions in different frameworks you use in the project. |
@goktugyil Can you please update for Swift4.2 in replacing UIWebview to WKWebView..as apple is rejecting the app's |
Please open or review a PR with the wanted changes |
Currently supporting latest branch to swift 4.2 ? or any other branch ?
The text was updated successfully, but these errors were encountered: