Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Display to signature types #482

Open
ggutoski opened this issue Feb 6, 2024 · 2 comments
Open

Add Display to signature types #482

ggutoski opened this issue Feb 6, 2024 · 2 comments
Assignees
Labels
cappuccino cappuccino-sprint1 tech debt Technical debt. We all pay eventually!

Comments

@ggutoski
Copy link
Contributor

ggutoski commented Feb 6, 2024

Need Display trait bound for

  • jf_primitives::SignatureScheme::Signature
  • <Signature as TryFrom<TaggedBase64>>::Error

@QuentinI please add what you need to this issue.

@ggutoski ggutoski added tech debt Technical debt. We all pay eventually! cappuccino cappuccino-sprint1 labels Feb 6, 2024
@mrain
Copy link
Contributor

mrain commented Feb 6, 2024

Could you explain the use case here?
Most of the actual Signature structs already have Display derived from tagged macro.

@ggutoski ggutoski removed their assignment Feb 6, 2024
@QuentinI
Copy link

QuentinI commented Feb 7, 2024

@mrain

Could you explain the use case here?
Most of the actual Signature structs already have Display derived from tagged macro.

HotShot abstracts over some types, including Signatures, where it requires SignatureScheme, which means if hs-builder-core wants to abstract over those as well, it cannot rely on specific types' Display implementation.
I'm asking for new bounds in SignatureScheme:

  • SignatureScheme::Signature: Display
  • <<SignatureScheme::Signature> as TryFrom<TaggedBase64>>::Error: Display (or <SignatureScheme::Signature>: TryFrom<TaggedBase64, Error=Tb64Error>, since Tb64Error is Display and every Signature probably already uses Tb64Error)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cappuccino cappuccino-sprint1 tech debt Technical debt. We all pay eventually!
Projects
None yet
Development

No branches or pull requests

3 participants