Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Godot] Fail to build on latest versions #2680

Open
HKunogi opened this issue Nov 13, 2024 · 2 comments
Open

[Godot] Fail to build on latest versions #2680

HKunogi opened this issue Nov 13, 2024 · 2 comments
Assignees
Labels

Comments

@HKunogi
Copy link

HKunogi commented Nov 13, 2024

After latest godot commits the spine runtime fails to build as an engine module, it always worked before. The error is as follows:
[ 40%] Compiling modules\spine_godot\SpineIkConstraint.cpp ... modules\spine_godot\SpineBoneNode.cpp(194): warning C4458: declaration of 'global_transform' hides class member .\scene/main/canvas_item.h(120): note: see declaration of 'CanvasItem::global_transform' [ 40%] Compiling modules\spine_godot\SpinePathConstraint.cpp ... [ 40%] Compiling modules\spine_godot\SpinePathConstraintData.cpp ... [ 40%] Compiling modules\spine_godot\SpinePhysicsConstraint.cpp ... [ 40%] Compiling modules\spine_godot\SpinePhysicsConstraintData.cpp ... D:\Source\Other\gd-engine\modules\spine_godot\SpineEditorPlugin.h(111): error C3668: 'SpineAtlasResourceImportPlugin::import': method with override specifier 'override' did not override any base class methods D:\Source\Other\gd-engine\modules\spine_godot\SpineEditorPlugin.h(185): error C3668: 'SpineJsonResourceImportPlugin::import': method with override specifier 'override' did not override any base class methods D:\Source\Other\gd-engine\modules\spine_godot\SpineEditorPlugin.h(259): error C3668: 'SpineBinaryResourceImportPlugin::import': method with override specifier 'override' did not override any base class methods modules\spine_godot\SpineEditorPlugin.cpp(45): warning C4458: declaration of 'metadata' hides class member .\core/object/object.h(632): note: see declaration of 'Object::metadata' modules\spine_godot\SpineEditorPlugin.cpp(101): warning C4458: declaration of 'metadata' hides class member .\core/object/object.h(632): note: see declaration of 'Object::metadata' modules\spine_godot\SpineEditorPlugin.cpp(129): warning C4458: declaration of 'metadata' hides class member .\core/object/object.h(632): note: see declaration of 'Object::metadata' modules\spine_godot\SpineEditorPlugin.cpp(325): warning C4458: declaration of 'property' hides class member .\editor/editor_inspector.h(84): note: see declaration of 'EditorProperty::property' scons: *** [modules\spine_godot\SpineEditorPlugin.windows.editor.x86_64.obj] Error 2 scons: building terminated because of errors.
The issue seems to be due to this commit: godotengine/godot@fe34c45
The method arguments have changed.

@badlogic
Copy link
Collaborator

Thanks for reporting. This is for the master branch of Godot, which we can't support. We generally only support tagged Godot releases, as the Godot master branch changes so frequently and breaks APIs so much, that it's impossible to keep up.

I'll keep this open as a reminder for when the next Godot release happens that has this API change.

@badlogic
Copy link
Collaborator

Finally found the culprit.

godotengine/godot#95861 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants