Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts][threejs] Custom shader ignores light and shadows #2606

Open
davidetan opened this issue Aug 19, 2024 · 0 comments
Open

[ts][threejs] Custom shader ignores light and shadows #2606

davidetan opened this issue Aug 19, 2024 · 0 comments

Comments

@davidetan
Copy link
Collaborator

davidetan commented Aug 19, 2024 •
edited
Loading

As reported by a user in this forum thread, the custom shader we use to render our meshes does not take into consideration lights and shadows.

It seems that using the onBeforeCompile callback is possible to modify the threejs base shader rather than replacing it.

See this official example (code here).

Moreover, 0.158.0 adds support for BatchedMesh: https://github.com/mrdoob/three.js/releases/tag/r158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidetan