Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_fetch code sample #29

Open
hirenoble opened this issue Nov 8, 2019 · 2 comments
Open

Add node_fetch code sample #29

hirenoble opened this issue Nov 8, 2019 · 2 comments

Comments

@hirenoble
Copy link

Hi Erik,

First of all, thank you very much for creating this package. It works great!

The node_request target creates a code sample using the https://www.npmjs.com/package/request package but recently there was an announcement that this will be no longer supported. Hence, it would be great to add/update node code sample using https://www.npmjs.com/package/node-fetch

@ErikWittern
Copy link
Owner

@hirenoble Glad to hear you like the package!

Under the hood, it actually uses the httpsnippet library, which determines valid targets. I.e., you would have to file this issue with them to add support for other libraries.

@kbatuigas
Copy link

Hi @ErikWittern ! We see that https://github.com/Kong/httpsnippet/tree/master/src/targets/node/fetch has been added to httpsnippet, would it be possible to add support for this in openapi-snippet? cc @hirenoble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants