-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Option to customize the "Result" suffix appended when generating type names #2677
Comments
I think it is a good suggestion - but I think this could just be something you can manually add to the config file. Remember to also add to the CLI (or I can do that after your PR if you prefer) |
Ok, I will test with the CLI. |
Cool. Testing with the CLI is very simple. |
By the way, for a PR should I include updated zip files (efptxx.exe.zip & efrevengxx.exe.zip) or just the source code changes? |
Just the updated source code, the .zip files are always built in the github action |
@vanillabrian Is this still something you plan to work on? |
Yes, I still plan to work on this. I was delayed by some other priorities, but I am hoping to submit a PR as soon as possible. |
@vanillabrian Going to close this for now, feel free to re-open when you find time. |
This enhancement would allow slight customization of the default return type name. We have a large amount of code written with an older version of EF and the return type names were generated slightly differently. To ease the transition to EF Core it would be nice if the type names could be generated to match the ones previously generated to minimize code changes.
Currently, the return type names generated for store procedures and functions are generated by appending the suffix "Result" to the name of the procedure or function name. The return type for the procedure sp_ProcessSomeData would be sp_ProcessSomeDataResult.
The proposal is to add an option, Type Name Suffix, to the Advanced Options dialog windows to specify a customized suffix instead of the default 'Result". If nothing is specified 'Result' would be used as it is in the current version. So, if "_Result" was specified as the Type Name Suffix the return type name for the procedure mentioned above would be sp_ProcessSomeData_Result.
I have already implemented a proof of concept. Would you be open to a pull request?
The text was updated successfully, but these errors were encountered: