From 18b47373cb47f1f63ab1f6e126ccfb22cc52963c Mon Sep 17 00:00:00 2001 From: jmriesen <20286401+jmriesen@users.noreply.github.com> Date: Fri, 3 Jan 2025 15:18:39 -0600 Subject: [PATCH] Updating broken/outdated links in the ProgrammerManual (#119472) Fixes llvm/llvm-project#117897 --- llvm/docs/ProgrammersManual.rst | 6 +++--- llvm/include/llvm/IR/PassManager.h | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/llvm/docs/ProgrammersManual.rst b/llvm/docs/ProgrammersManual.rst index 98803ddffd0823..e2829eb5a8846d 100644 --- a/llvm/docs/ProgrammersManual.rst +++ b/llvm/docs/ProgrammersManual.rst @@ -3358,15 +3358,15 @@ the ``PassManager.h`` system, and there is a more detailed introduction to it by Sean Parent in several of his talks and papers: #. `Inheritance Is The Base Class of Evil - `_ + `_ - The GoingNative 2013 talk describing this technique, and probably the best place to start. #. `Value Semantics and Concepts-based Polymorphism `_ - The C++Now! 2012 talk describing this technique in more detail. #. `Sean Parent's Papers and Presentations - `_ - - A GitHub project full of links to slides, video, and sometimes code. + `_ + - Links to slides, videos, and sometimes code. When deciding between creating a type hierarchy (with either tagged or virtual dispatch) and using templates or concepts-based polymorphism, consider whether diff --git a/llvm/include/llvm/IR/PassManager.h b/llvm/include/llvm/IR/PassManager.h index 5dab9d0d0a7979..b5230047b0e128 100644 --- a/llvm/include/llvm/IR/PassManager.h +++ b/llvm/include/llvm/IR/PassManager.h @@ -28,9 +28,9 @@ /// polymorphism as outlined in the "Value Semantics and Concept-based /// Polymorphism" talk (or its abbreviated sibling "Inheritance Is The Base /// Class of Evil") by Sean Parent: -/// * http://github.com/sean-parent/sean-parent.github.com/wiki/Papers-and-Presentations +/// * https://sean-parent.stlab.cc/papers-and-presentations /// * http://www.youtube.com/watch?v=_BpMYeUFXv8 -/// * http://channel9.msdn.com/Events/GoingNative/2013/Inheritance-Is-The-Base-Class-of-Evil +/// * https://learn.microsoft.com/en-us/shows/goingnative-2013/inheritance-base-class-of-evil /// //===----------------------------------------------------------------------===//