Skip to content

Commit cd21aa0

Browse files
fix: more missing functions (#1001)
* fix: more missing funcitons * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * fix: update isless/!=/== * fix: avoid conversion * fix: dispatch --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
1 parent 9f6cf21 commit cd21aa0

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

ext/ReactantCUDAExt.jl

+6-5
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,18 @@ for jlop in (
6363
:(Base.:/),
6464
:(Base.:^),
6565
:(Base.rem),
66+
:(Base.isless),
67+
:(Base.:(==)),
68+
:(Base.:(!=)),
6669
)
6770
@eval begin
6871
@inline $jlop(a::CuTracedRNumber, b::CuTracedRNumber) = $jlop(a[], b[])
72+
@inline $jlop(a::CuTracedRNumber{T,A}, b::Number) where {T,A} = $jlop(a[], b)
73+
@inline $jlop(a::Number, b::CuTracedRNumber{T,A}) where {T,A} = $jlop(a, b[])
6974
end
7075
end
7176

72-
for jlop in (:(Base.:+), :(Base.:-))
77+
for jlop in (:(Base.:+), :(Base.:-), :(Base.isnan), :(Base.isfinite), :(Base.isinf))
7378
@eval begin
7479
@inline $jlop(a::CuTracedRNumber) = $jlop(a[])
7580
end
@@ -117,10 +122,6 @@ end
117122

118123
Base.convert(::Type{<:CuTracedRNumber{T}}, x::CuTracedRNumber{T}) where {T} = x
119124

120-
Base.isless(a::CuTracedRNumber, b::CuTracedRNumber) = Base.isless(a[], b[])
121-
Base.isless(a, b::CuTracedRNumber) = Base.isless(a, b[])
122-
Base.isless(a::CuTracedRNumber, b) = Base.isless(a[], b)
123-
124125
Base.one(a::CuTracedRNumber) = one(a[])
125126
Base.one(::Type{<:CuTracedRNumber{T,A}}) where {T,A} = one(T)
126127
Base.zero(a::CuTracedRNumber) = zero(a[])

0 commit comments

Comments
 (0)