From 4b0d07e6aca1d9b8d1698fc0cb191e9596b46dca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mos=C3=A8=20Giordano?= Date: Sat, 1 Feb 2025 20:17:40 +0000 Subject: [PATCH] [ReactantCUDAExt] Skip precompile load on Julia v1.11.3 --- ext/ReactantCUDAExt.jl | 6 ++++-- test/integration/cuda.jl | 3 --- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/ext/ReactantCUDAExt.jl b/ext/ReactantCUDAExt.jl index 391be0bd9..9c9dd3b5f 100644 --- a/ext/ReactantCUDAExt.jl +++ b/ext/ReactantCUDAExt.jl @@ -952,12 +952,14 @@ function __init__() return nothing end -@static if !Sys.isapple() && Sys.ARCH != :aarch64 +# In Julia v1.11.3 precompiling this module caches bad code: +# . +@static if !Sys.isapple() Reactant.PrecompileTools.@setup_workload begin Reactant.initialize_dialect() client = Reactant.XLA.CPUClient(; checkcount=false) Reactant.PrecompileTools.@compile_workload begin - @static if Reactant.precompilation_supported() + @static if Reactant.precompilation_supported() && VERSION != v"1.11.3" function square_kernel!(x) i = CUDA.threadIdx().x x[i] *= x[i] diff --git a/test/integration/cuda.jl b/test/integration/cuda.jl index 1a95de9b6..9641609fe 100644 --- a/test/integration/cuda.jl +++ b/test/integration/cuda.jl @@ -17,9 +17,6 @@ function square!(x, y) return nothing end -# https://github.com/EnzymeAD/Reactant.jl/issues/614 -const skip_non_cuda_tests = true - @static if !Sys.isapple() @testset "Square Kernel" begin oA = collect(1:1:64)