-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pick_batchsize
#1545
base: main
Are you sure you want to change the base?
Implement pick_batchsize
#1545
Conversation
Should this be renamed to |
Sure, batchsize sgtm. |
Otherwise, this looks good to me once test pass |
I think test failures are unrelated? The tests I introduced pass locally |
is this acceptable? it's hard to know given all the failing tests |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1545 +/- ##
==========================================
+ Coverage 67.50% 71.63% +4.12%
==========================================
Files 31 32 +1
Lines 12668 13816 +1148
==========================================
+ Hits 8552 9897 +1345
+ Misses 4116 3919 -197 ☔ View full report in Codecov by Sentry. |
@gdalle CI here seems really just blocked by this PR. e.g.
|
My bad, I thought EnzymeCore was available for testing. I removed it from the test file |
@wsmoses this should be good to go? |
@vchuravy this looks like an easy merge? |
Sorry I inadvertently formatted the code, will fix the diff |
Fix #1542 by implementing a constant heuristic for picking chunk size.