Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with feedback lines #1045

Open
swilliamson7 opened this issue Sep 11, 2023 · 10 comments
Open

Issue with feedback lines #1045

swilliamson7 opened this issue Sep 11, 2023 · 10 comments

Comments

@swilliamson7
Copy link
Collaborator

@wsmoses This is the bug we saw when I include the feedback lines which effectively just share things such as model integration time, NaN checks, etc.

feedback_error.txt

@wsmoses
Copy link
Member

wsmoses commented Sep 11, 2023 via email

@swilliamson7
Copy link
Collaborator Author

I'll need to check if I have a standalone script that can produce this, but at the very least can show you the code tomorrow otherwise? I'll work on making a file I can post here in any case (assuming I don't have one)

@wsmoses
Copy link
Member

wsmoses commented Nov 28, 2023

@swilliamson7 any chance you have a reproducer for this?

@swilliamson7
Copy link
Collaborator Author

I'll create a minimal example

@wsmoses
Copy link
Member

wsmoses commented Feb 10, 2024

bumping this @swilliamson7

@swilliamson7
Copy link
Collaborator Author

Sorry for the delay! I minimized a bit, and can try working on it more later

Running this script will trigger Enzyme bugs seemingly related to lines that just provide feedback on the integration or initialize netcdf output

@wsmoses
Copy link
Member

wsmoses commented May 7, 2024

@swilliamson7 does this still err?

@swilliamson7
Copy link
Collaborator Author

Last I checked yes

@wsmoses
Copy link
Member

wsmoses commented Sep 21, 2024

@swilliamson7 I don't see a file at the linked script. Do you have something that still errs [we also since fixed a bunch of things]

@swilliamson7
Copy link
Collaborator Author

Yeah things have been moved around since May. I think I still get this bug, but have just been omitting the lines of code that cause it. We can either (a) leave this open and in the coming days I'll create a new script that leads to it or (b) close this issue and I'll reopen whenever I get around to looking at it more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants