Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for CustomSoftwareSerial library? #19

Open
KhurramFHassan opened this issue Sep 16, 2021 · 1 comment
Open

Support for CustomSoftwareSerial library? #19

KhurramFHassan opened this issue Sep 16, 2021 · 1 comment

Comments

@KhurramFHassan
Copy link

First of all, I must say that it is a joy to use your library; its simple yet does all (except 1) I require to interface with my modbus device to an arduino nano. The only issue is that my modbus device required 8N2 (and the nano has only 1 hardware serial connected to the pc usb); so I cant use AltSoftSerial or SoftwareSerial. Would it be possible for you to add support for the CustomSoftwareSerial library (https://github.com/ledongthuc/CustomSoftwareSerial)?

Thanks

@SRGDamia1
Copy link
Contributor

I'm catching up on issues after 3 months on leave.

CustomSoftwareSerial should already work with this library. The constructor requires a Stream object. Quickly looking at the source code for CustomSoftwareSerial, that library does inherit from Stream, so you should be good to go.

Did it not work as you expected? If not, what didn't work? (ie, couldn't compile, crashed on run, didn't get data, data was garbled, etc)

If you've already figured out whatever was wrong before I got to this, could you please post the solution and close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants