Cmdct 4229 - pre-populate drawer with plans #11995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmrabian
reviewed
Jan 9, 2025
karla-vm
reviewed
Jan 9, 2025
|
Other than the comment I added, I agree with all of @gmrabian's comments above! This is looking really good, we just need to clean up a couple of things 😄 |
britt-mo
requested review from
BearHanded,
braxex and
jessabean
as code owners
gmrabian
previously approved these changes
Jan 10, 2025
|
Code Climate has analyzed commit 72799e7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 97.2% (90% is the threshold). This pull request will bring the total coverage in the repository to 96.7% (0.0% change). View more on Code Climate. |
gmrabian
approved these changes
Jan 13, 2025
bangbay-bluetiger
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main goal here is to populate the list of plans that appears when you go into a drawer in the analysis methods page in a NAAAR report. The logic to do so already existed for ILOS so this is my attempt to generalize that functionality.
Related ticket(s)
CMDCT-4229
How to test
Create a MCPAR report, add a plan, add an ILOS, go to section D -> ILOS, enter the plan, answer 'yes', see the ilos appears.
Create a NAAAR report, add a plan, go to the analysis methods page and enter one of them, answer 'yes', see the plan appears under the frequency question and radio button options. See that it is the same when adding a new analysis method.
Notes
Pre-review checklist
Pre-merge checklist
Review
Security
If either of the following are true, notify the team's ISSO (Information System Security Officer).
convert to a different template: test → val | val → prod