Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mcpar form e2e fix #11935

Merged
merged 39 commits into from
Nov 25, 2024
Merged

Mcpar form e2e fix #11935

merged 39 commits into from
Nov 25, 2024

Conversation

britt-mo
Copy link
Contributor

@britt-mo britt-mo commented Nov 21, 2024

Description

the form test for mcpar was failing after I merged my report footer changes because of a template/path mismatch along with drawerForm steps that did not account for the Prior Authorization section logic.

Related ticket(s)

CMDCT-4125


How to test

Notes


Pre-review checklist

  • I have added thorough tests, if necessary
  • I have updated relevant documentation, if necessary
  • I have performed a self-review of my code
  • I have manually tested this PR in the deployed cloud environment

Pre-merge checklist

Review

  • Design: This work has been reviewed and approved by design, if necessary
  • Product: This work has been reviewed and approved by product owner, if necessary

Security

If either of the following are true, notify the team's ISSO (Information System Security Officer).

  • These changes are significant enough to require an update to the SIA.
  • These changes are significant enough to require a penetration test.

convert to a different template: test → val | val → prod

britt-mo added 23 commits July 16, 2024 13:39
gmrabian
gmrabian previously approved these changes Nov 21, 2024
Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Copy link
Contributor

@gmrabian gmrabian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why MLR is failing now 🤔

@britt-mo
Copy link
Contributor Author

britt-mo commented Nov 21, 2024

not sure why MLR is failing now 🤔

@gmrabian Re-running, might just be flaky

@britt-mo
Copy link
Contributor Author

@gmrabian nvm, it does to seem to be broken. Will work on this after meetings cause I doubt I can run cypress tests locally while also being on a Zoom call lol

@bangbay-bluetiger bangbay-bluetiger self-assigned this Nov 22, 2024
@bangbay-bluetiger bangbay-bluetiger mentioned this pull request Nov 22, 2024
8 tasks
@karla-vm karla-vm merged commit ec8d3f3 into main Nov 25, 2024
17 checks passed
@karla-vm karla-vm deleted the mcpar-form-e2e-fix branch November 25, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants