New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak with cooldowns #9

Open

idkw opened this issue Mar 31, 2016 · 1 comment

idkw commented Mar 31, 2016

Cooldowns are never cleared for players that log out.
This causes the timers map to grow without removing old players.

Line 148 in https://github.com/Eniripsa96/EnchantmentPack/blob/master/EnchantActivePack/src/com/sucy/active/ConfigurableEnchantment.java

It adds a player to the map but there is nowhere the code that removes the player from this map when he logs out.

You could clear the map from this class :
https://github.com/Eniripsa96/EnchantmentPack/blob/master/EnchantActivePack/src/com/sucy/active/EPListener.java
It already listens to PlayerQuitEvent so it seems to be a good fit for this purpose.

PiggiesGoSqueal commented Dec 8, 2018

Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment