Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Odd results for objectives that don't return an asset dimension #581

Closed
tsmbland opened this issue Nov 27, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@tsmbland
Copy link
Collaborator

Some of the objectives (namely "capital_costs", "comfort", "efficiency" and "ALCOE") don't return an asset dimension, and I've noticed some strange behavior when using these objectives (e.g. not investing in the technologies you'd expect), or more often the model hits a growth error and fails to run.

I think the place where this is causing problems is the _unified_dataset function, although that function is so unreadable it's hard to see what it's supposed to be doing.

Simply adding an asset dimension to these objectives by broadcasting looks like it's enough to fix the problem (#580), and gives much more sensible results. That may end up being the best solution.

I've also noticed that this bug only applies when using these objectives as single objectives (or multi-objective with each other). I guess that when you combine these with another objective that does have an asset dimension, then automatic broadcasting occurs at that point, so by the time it get's passed to _unified_dataset it's all good.

@tsmbland tsmbland added the bug Something isn't working label Nov 27, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in MUSE Nov 27, 2024
@tsmbland tsmbland added this to the v1.2.4 milestone Nov 27, 2024
@tsmbland tsmbland removed this from the v1.2.4 milestone Nov 29, 2024
@tsmbland
Copy link
Collaborator Author

Closed by #584

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in MUSE Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant