Skip to content

Commit 1cc3944

Browse files
committed
Port opensearch to QJSEngine to prepare for QT6
1 parent e4f83df commit 1cc3944

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

src/CMakeLists.txt

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ find_package(Qt5WebEngineWidgets REQUIRED)
2626
find_package(Qt5PrintSupport REQUIRED)
2727
find_package(Qt5UiTools)
2828
find_package(Qt5LinguistTools REQUIRED)
29-
find_package(Qt5Script REQUIRED)
29+
find_package(Qt5Qml REQUIRED)
3030

3131
if(NOT Qt5UiTools_FOUND)
3232
add_definitions(-DQT_NO_UITOOLS)
@@ -179,8 +179,8 @@ qt5_use_modules(endorphin WebEngine)
179179
qt5_use_modules(endorphin Network)
180180
qt5_use_modules(endorphin WebEngineWidgets)
181181
qt5_use_modules(endorphin PrintSupport)
182+
qt5_use_modules(endorphin Qml)
182183

183184
if(Qt5UiTools_FOUND)
184185
qt5_use_modules(endorphin UiTools)
185186
endif()
186-
qt5_use_modules(endorphin Script)

src/opensearch/opensearchengine.cpp

+6-5
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#include <qnetworkreply.h>
2929
#include <qregexp.h>
3030
#include <qstringlist.h>
31-
#include <QScriptEngine>
31+
#include <QJSEngine>
3232
#include <QUrlQuery>
3333

3434
/*!
@@ -543,19 +543,20 @@ void OpenSearchEngine::suggestionsObtained()
543543
return;
544544

545545
if (!m_scriptEngine)
546-
m_scriptEngine = new QScriptEngine();
546+
m_scriptEngine = new QJSEngine();
547547

548548
// Evaluate the JSON response using QtScript.
549-
if (!m_scriptEngine->canEvaluate(response))
549+
if (m_scriptEngine->evaluate(response).isError())
550550
return;
551551

552-
QScriptValue responseParts = m_scriptEngine->evaluate(response);
552+
QJSValue responseParts = m_scriptEngine->evaluate(response);
553553

554554
if (!responseParts.property(1).isArray())
555555
return;
556556

557557
QStringList suggestionsList;
558-
qScriptValueToSequence(responseParts.property(1), suggestionsList);
558+
559+
suggestionsList = responseParts.property(1).toVariant().toStringList();
559560

560561
emit suggestions(suggestionsList);
561562
}

src/opensearch/opensearchengine.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
#include <qurl.h>
2929

3030
class QNetworkReply;
31-
class QScriptEngine;
31+
class QJSEngine;
3232

3333
class OpenSearchEngineDelegate;
3434
class OpenSearchEngine : public QObject
@@ -135,7 +135,7 @@ private slots:
135135
QNetworkAccessManager *m_networkAccessManager;
136136
QNetworkReply *m_suggestionsReply;
137137

138-
QScriptEngine *m_scriptEngine;
138+
QJSEngine *m_scriptEngine;
139139

140140
OpenSearchEngineDelegate *m_delegate;
141141
};

0 commit comments

Comments
 (0)