New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`RewardAddress`, `BaseAddress`, `EnterpriseAddress`, `PointerAddress` have no getter for network id #660

Closed

klntsky opened this issue Jan 22, 2024 · 4 comments

klntsky commented Jan 22, 2024

Address type does have it, but it is not convenient to convert every time a network id is needed.

The text was updated successfully, but these errors were encountered:

Contributor

lisicky commented Jan 25, 2024

Hi @klntsky! Hm we can add it in the next version : )

gitmachtl commented Jan 25, 2024

wasn't the PointerAddresssupposed to 'die', because noone ever used it? should it than being removed from the lib?

Contributor

lisicky commented Jan 25, 2024

@gitmachtl if it will be removed from the next CDDL we can deprecate PointerAddress in the CSL API.
But as I see it still exists in the conway CDDL https://github.com/IntersectMBO/cardano-ledger/blob/5f76eb918c16645ed98a7fbab513c2d549837ed5/eras/conway/impl/cddl-files/conway.cddl#L264-L265

Contributor

lisicky commented Aug 12, 2024

the lates CSL 12 should have it

lisicky closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment