Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for v6 #309

Open
nitin710 opened this issue Jun 7, 2024 · 1 comment
Open

Add support for v6 #309

nitin710 opened this issue Jun 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@nitin710
Copy link
Collaborator

nitin710 commented Jun 7, 2024

Describe the feature

  • Update the firmware to add support for new variant of LED driver. This variant runs on a different I2C address.
    • I2C address change from $70 (0x38) to $72 (0x39)
@nitin710 nitin710 added the enhancement New feature or request label Jun 7, 2024
@nitin710
Copy link
Collaborator Author

nitin710 commented Jun 7, 2024

Design

Questions

  1. Who should own the address information?

    • Option 1: We could add the second address in the EmotiBit_NCP class
      • by changing being to have a version input, .begin(*TwoWire, enum EmotiBItVersion), we can pass hte version from emotibit class on sensor init and set the correct address.
    • Option 2: We could create a new class LedController that stores this metadata. This class can have wrapper functions for all NCP deriver member_functions.
  2. If we are using a LedController class, should it initialize hw settings based on version sent by emotibit class?

    • Option 1: the LedController class can have the if() block on the emotibit version. But then, this controller class must be aware of the versionController class.
    • Option 2: If we don't want to create version based if blocks, then the hw information must come from the NVM. We would have to (1)change how the information is written on the NVM, (2)store sensor hw details and (3)grant the controller NVM access.

LedController class design

image

@nitin710 nitin710 mentioned this issue Jun 11, 2024
7 tasks
@nitin710 nitin710 reopened this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant