NullPointerException + fix

[fbernhard]

Hi there

I have encountered a NullPointerException in com.calclab.emite.im.roster.XmppRosterImpl: "presence.getShow()" can return null.

The following fixes it:

index 2839d03..f867946 100644
--- a/src/main/java/com/calclab/emite/im/roster/XmppRosterImpl.java
+++ b/src/main/java/com/calclab/emite/im/roster/XmppRosterImpl.java
@@ -102,7 +102,8 @@ public final class XmppRosterImpl implements XmppRoster, SessionStatusChangedEve
}
}

•                   if (!presence.getShow().equals(item.getShow())) {
  

•                   if (presence.getShow() != null && !presence.getShow().equals(item.getShow())
  

•                                   || presence.getShow() == null && item.getShow() != null) {
                          hasChanged = true;
                          item.setShow(presence.getShow());
                  }
  

[ashward]

Thanks for that. Looks sensible. I'll add that patch in :)

[ghost]

can you add this fix ... i have got this issue class: XmppRosterImpl line 107 code:
if (!presence.getShow().equals(item.getShow())) {
hasChanged = true;
item.setShow(presence.getShow());
}
i have got null pointer exception because prosence.getShow == null and item.getShow() == null