Use of SessionStates.ready.equals(state) problems

[danigb]

Reported by project member vruiz.jurado, Feb 20, 2011
The use of:
SessionStates.ready.equals(state) or SessionStates.isReady
gives wrongs values when you are at "Ready" state and you goes to the "RosterReady" state (for instance).

As a result instead of be logged, Hablar seems disconnected, your roster is inactive and Login Page shows "Wait..." instead of the Logout button.

How to test it: Active the LoginPage and try to login/logout several times. You will see that you can login only one time (when the browser load Hablar).

How to fix it: Use session.isReady() (in XmppSession) instead of SessionStates.ready.equals(state), or fix SessionState.isReady.

[danigb]

Better isReady method. Closed by 6bb77c7

[vjrj]

I think it's not enough to close the bug. Search the uses of SessionStates.ready (for instance in RosterPresenter.java or HablarRoster.java and others).