Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with filtered PLP and history #183

Open
evs-xsarus opened this issue May 14, 2024 · 4 comments
Open

Issues with filtered PLP and history #183

evs-xsarus opened this issue May 14, 2024 · 4 comments

Comments

@evs-xsarus
Copy link
Contributor

Issue Brief

What is the purpose of this issue? Explain the background context.

Environment

  • PHP Version: 8.3
  • Magento Version: 2.4.7
  • Tweakwise Version: 6.0.1
  • Tweakwise Export Version:
  • Magento Deploy Mode: production
  • Third party modules: tweakwise/magento2-attributelanding-tweakwise

Steps to reproduce

  1. Create a landing page for multiple brands.
  2. filter a PLP on 2 or more of these brands
  3. deselect a brand

Actual result

It's not possible to deselect a brand.

Expected result

The brand is deselected and the results reloaded.

Workaround

For now, I've fixed this with this change:

--- a/vendor/tweakwise/magento2-tweakwise/view/frontend/web/js/navigation-form.js
+++ b/vendor/tweakwise/magento2-tweakwise/view/frontend/web/js/navigation-form.js
@@ -25,7 +25,7 @@
             noteMessageSelector: '.message.note',
             noticeMessageSelector: '.message.notice',
             isLoading: false,
-            ajaxCache: true,
+            ajaxCache: false,
         },

         currentXhr: null,
@ah-net
Copy link
Collaborator

ah-net commented May 21, 2024

@evs-xsarus I can't reproduce the issue.

The ajaxCache should not be an issue because the url's should be different. Can you give an screenshot of the tweakwise/layered navigation settings? So i can see if i can reproduce it using the same settings?
Is it possible to make an clip of the problem including the used url's?

@ah-net ah-net closed this as not planned Won't fix, can't repro, duplicate, stale Jul 23, 2024
@evs-xsarus
Copy link
Contributor Author

@ah-net Sorry, I missed this comment. Could you reopen the ticket. Here's the screenshot:

image

The error is happening on https://www.telstarsurf.nl/

@ah-net ah-net reopened this Jul 23, 2024
@ah-net
Copy link
Collaborator

ah-net commented Jul 23, 2024

@evs-xsarus I think this may be the same problem as EmicoEcommerce/Magento2AttributeLandingTweakwise#31

Can you check if that pull request fixes it?

@evs-xsarus
Copy link
Contributor Author

@ah-net sadly, the problem persists in v4.3.5 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants