Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Ember 3.22 error on destroy #129

Open
gedaiu opened this issue Oct 20, 2020 · 6 comments
Open

Ember 3.22 error on destroy #129

gedaiu opened this issue Oct 20, 2020 · 6 comments

Comments

@gedaiu
Copy link

gedaiu commented Oct 20, 2020

It looks like this component is broken when used with ember 3.22:

Uncaught Error: Assertion Failed: You attempted to update `_swiper` on `<ogm@component:swiper-container::ember424>`, but it had already been used previously in the same computation.  Attempting to update a value after using it in a computation can cause logical errors, infinite revalidation bugs, and performance issues, and is not supported.

`_swiper` was first used:

- While rendering:
  application
    browse
      browse.sites

Stack trace for the update:
@maxymczech
Copy link

Also getting this error in debug environment, it is fine in production though.

@dougestey
Copy link

Can confirm this is happening over here too.

@dougestey
Copy link

dougestey commented Mar 30, 2021

@Matt-Jensen Thoughts on this? It fixes the error, but I don't know enough about the internals of Swiper to be sure. If you think it's fine, I'll PR on this repo.

I think calling .destroy is enough, judging from their docs:
Screenshot 2021-03-30 134043

@Matt-Jensen
Copy link
Contributor

I don't work with Ember that much anymore. However if you have a fix for this issue I'd be more than happy to publish it!

@dougestey
Copy link

Thanks Matt - do you know who is maintaining this repo currently?

@Matt-Jensen
Copy link
Contributor

Whomever wants to!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants