Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace breakpad-sys with Rust #4

Open
Jake-Shadle opened this issue Apr 14, 2021 · 3 comments
Open

Replace breakpad-sys with Rust #4

Jake-Shadle opened this issue Apr 14, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@Jake-Shadle
Copy link
Member

The original motivation for this repo/crate(s) was to replace our dependency on the significantly heavier combination of sentry-native and sentry-contrib-native with a smaller and simpler way to capture and report native crashes, which it does well as we have been using it for almost half a year now with no issues.

However, any C++ is too much C++, especially when it gets in the way of our development, namely in the case of wanting to compile with musl libc so that can have small static binaries for services running in docker containers that support crash reporting still, but is screwed up due to Breakpad's use of C++.

A significant amount of the Breakpad code is just the usual C++ shenanigans of having custom string functions and guid creation and blah blah, stuff that we don't need in Rust or have excellent crates for, as well as a lot of code dedicated for platforms that we will never care about (wtf still runs Solaris!?) leaving the actual code that needs to be ported to Rust to be quite small, at least relative to the total amount of source in Breakpad.

@Jake-Shadle Jake-Shadle added the enhancement New feature or request label Apr 14, 2021
@Jake-Shadle
Copy link
Member Author

Linking getsentry/symbolic#375 as this issue also includes minidump generation on the platforms we (currently) care about.

@Jake-Shadle
Copy link
Member Author

Now that https://github.com/EmbarkStudios/crash-handling exists we can create a pure Rust implementation to integrate crash handling with Sentry and completely get rid of the C++ mess in Breakpad.

@Jake-Shadle Jake-Shadle self-assigned this Dec 16, 2022
@Jake-Shadle
Copy link
Member Author

In addition, we ideally would just have our own simpler implementation of the sentry sdk that is capable of sending over data to the crash handler process so that things like tags, breadcrumbs, etc are automatically added to crash events, as, unfortunately, this is not really doable with the official sentry sdk itself in a good way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant