Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile component #23

Open
2 tasks
koraytaylan opened this issue Jan 21, 2019 · 3 comments
Open
2 tasks

Profile component #23

koraytaylan opened this issue Jan 21, 2019 · 3 comments
Assignees
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Milestone

Comments

@koraytaylan
Copy link
Contributor

Using data services implemented in #22,

Points of discussion,

  • Does it make sense to generify data tables or treat each page as individual
  • How will we handle sorting and filtering
  • Should editor be implemented as a modal component or as a separate page
@koraytaylan koraytaylan added help wanted Extra attention is needed good first issue Good for newcomers labels Jan 21, 2019
@koraytaylan koraytaylan added this to the pre-alpha-1 milestone Jan 21, 2019
@mumincelal
Copy link

  • Filtering might be according to "Name Surname" and all columns can be sort able individually.
  • Modals give complicated view, separate page is well in my opinion. When we use separate page, editor view will be more simple.

@begumerden
Copy link

begumerden commented Feb 11, 2019

  • For profile list;
    I have two alternatives:

1-With this we can use ant design built-in funcitonalities for delete and edit image
2 - image

@ilhan-mstf
Copy link

I think both of them have similar functionality. We can go further which one is easier to implement. In the future, we will require "delete selected" functionality with check boxes. (I think adding edit and delete button every column reduces the step count, therefore it would be better if we have edit and delete button every column in the second design as well)

@begumerden begumerden self-assigned this Feb 15, 2019
mmayadag pushed a commit that referenced this issue Feb 15, 2019
…le-list

# Conflicts:
#	src/scripts/components/profile/ProfileList.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants