New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code style fixes/linting (Rubocop) #812

Open

5 tasks

fbacall opened this issue Feb 8, 2023 · 1 comment

Labels

Milestone

Member

fbacall commented Feb 8, 2023

The code could use a clean up, lots of style inconsistencies dotted around. Rubocop has an -a flag to automatically fix style issues.

(optional) Create a .rubocop.yml with rule tweaks.
(optional) Install https://github.com/Shopify/erb-lint for linting .erb files.
Run rubocop -a on the code (and erb-lint).
Create a CI step to flag code style issues.
Update contributor documentation to mention how to lint code.

The text was updated successfully, but these errors were encountered:

fbacall added the improvement label

fbacall added this to the 1.4.0 release milestone

Member Author

fbacall commented Feb 8, 2023

Also something to check JavaScript/CSS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment