Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning-blacklistrune future (not yet existing) runes #7017

Open
Amperstrand opened this issue Jan 26, 2024 · 1 comment · May be fixed by #8037
Open

lightning-blacklistrune future (not yet existing) runes #7017

Amperstrand opened this issue Jan 26, 2024 · 1 comment · May be fixed by #8037
Assignees
@rustyrussell
Milestone
v25.02

Comments

@Amperstrand
Copy link

If you want to blacklist all runes for some reason you might decide to run the command

lightning-cli blacklistrune 0 99

Or even worse: 0 99999

At first you might exepct that this will blacklist all existing runes between 0 and 99999

When you generate a new rune, this new rune will be on the blacklist. I'm not sure how to resolve this other then creating 99999 blacklisted runes.

What I might have expected is that lightning-cli blacklistrune 0 99 would blacklist all runes from 0 to 11 and then maybe given an error message about being unable to blacklist rune 12.

Creating this issue to propose that blacklistrune should not blacklist a non-existing rune.

An alternative approach to destroying all runes would be to have blacklistrune be able to take the parameter all to destroy all runes.

lightning-cli blacklistrune
@Amperstrand
Copy link
Author

to blacklist all runes:

alias lcli_blacklistallrunes="lightning-cli blacklistrune 0 $(lightning-cli showrunes | jq -r '.runes | map(select(.blacklisted == null)) | max_by(.unique_id | tonumber).unique_id')"

@rustyrussell rustyrussell added this to the v25.02 milestone Jan 24, 2025
@rustyrussell rustyrussell self-assigned this Jan 24, 2025
@rustyrussell rustyrussell linked a pull request Jan 28, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rustyrussell rustyrussell

Labels
None yet
Projects
None yet
Milestone
v25.02
Development

Successfully merging a pull request may close this issue.

Ability to unblacklist runes rustyrussell/lightning
2 participants
@rustyrussell @Amperstrand