-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mockup] block and element highlighting #255
Comments
let me know what you think-- is this a direction you'd want to explore? |
Yep. |
This looks nice! A few thoughts:
Other than that, I'm loving this feature! |
I pushed what I have to Airhogs777/elemental:element-highlighting (diff). Keep in mind that this is a really rough implementation and it'll need some work to do things like garbage collection
good ideas, I'll experiment with both |
Aagh sorry, out of habit I pushed to my own repo instead of this one. When I create a PR it'll be on this repo |
I deleted my elemental repo to simplify future PRs, the code for this is now in the branch element-highlighting on this repo |
Perhaps there should be rounded corners around the gold outline? |
Okay, I'll experiment with this a little when I have a free moment |
I had an epiphany a couple hours ago and threw together this mockup:
I have code that works but it's dependent on #249 and could use some refinement
The text was updated successfully, but these errors were encountered: