Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mockup] block and element highlighting #255

Open
mrjacobbloom opened this issue Apr 17, 2017 · 8 comments
Open

[mockup] block and element highlighting #255

mrjacobbloom opened this issue Apr 17, 2017 · 8 comments

Comments

@mrjacobbloom
Copy link
Contributor

I had an epiphany a couple hours ago and threw together this mockup:
out
I have code that works but it's dependent on #249 and could use some refinement

@mrjacobbloom
Copy link
Contributor Author

let me know what you think-- is this a direction you'd want to explore?

@iamunknown2
Copy link
Contributor

iamunknown2 commented Apr 17, 2017

Yep.
Perhaps you could push a fork of your repo branch (but containing this feature) to here?

@PullJosh
Copy link
Contributor

PullJosh commented Apr 17, 2017

This looks nice! A few thoughts:

  1. Make it toggleable (turn the feature on/off)
  2. Highlight both the element and the block, not one or the other.

Other than that, I'm loving this feature!

@mrjacobbloom
Copy link
Contributor Author

mrjacobbloom commented Apr 17, 2017

Perhaps you could push a fork of your repo branch (but containing this feature) to here?

I pushed what I have to Airhogs777/elemental:element-highlighting (diff). Keep in mind that this is a really rough implementation and it'll need some work to do things like garbage collection

  1. Make it toggleable (turn the feature on/off)
  2. Highlight both the element and the block, not one or the other.

good ideas, I'll experiment with both

@mrjacobbloom
Copy link
Contributor Author

mrjacobbloom commented Apr 17, 2017

Aagh sorry, out of habit I pushed to my own repo instead of this one. When I create a PR it'll be on this repo

@mrjacobbloom
Copy link
Contributor Author

I deleted my elemental repo to simplify future PRs, the code for this is now in the branch element-highlighting on this repo

@iamunknown2
Copy link
Contributor

iamunknown2 commented Apr 23, 2017

Perhaps there should be rounded corners around the gold outline? outline-radius doesn't seem to be standardized, so maybe we should use border instead of outline?

@mrjacobbloom
Copy link
Contributor Author

Okay, I'll experiment with this a little when I have a free moment

This was referenced May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants