Skip to content

Commit 4458f08

Browse files
Revert "Added handlekeydown event in panel component to close panel on escape key (#982)" (#1008)
This reverts commit 6a492b2.
1 parent 6dc4250 commit 4458f08

File tree

3 files changed

+1
-28
lines changed

3 files changed

+1
-28
lines changed

src/components/Panel/Panel.test.tsx

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -148,18 +148,6 @@ describe('Panel', () => {
148148
expect(wrapper.find('.button-primary').text()).toBe('Close');
149149
});
150150

151-
test('Should call onClose when escape key is pressed', () => {
152-
const onClose = jest.fn();
153-
wrapper.setProps({
154-
visible: true,
155-
onClose,
156-
});
157-
158-
// Simulate escape key press
159-
const escapeKeyEvent = new KeyboardEvent('keydown', { key: 'Escape' });
160-
document.dispatchEvent(escapeKeyEvent);
161-
});
162-
163151
test('Should render content when renderContentAlways is true', () => {
164152
const { getByText } = render(
165153
<Panel renderContentAlways>

src/components/Panel/Panel.tsx

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import React, {
66
useImperativeHandle,
77
useRef,
88
useState,
9-
useCallback,
109
} from 'react';
1110
import GradientContext, { Gradient } from '../ConfigProvider/GradientContext';
1211
import { OcThemeName } from '../ConfigProvider';
@@ -138,19 +137,6 @@ export const Panel = React.forwardRef<PanelRef, PanelProps>(
138137
);
139138
}, [mergedLocale]);
140139

141-
const handleEscapeKey = useCallback((event: KeyboardEvent) => {
142-
if (event.key === 'Escape' && visible) {
143-
onClose?.(event);
144-
}
145-
}, [onClose, visible]);
146-
147-
useEffect(() => {
148-
document.addEventListener('keydown', handleEscapeKey);
149-
return () => {
150-
document.removeEventListener('keydown', handleEscapeKey);
151-
};
152-
}, [handleEscapeKey]);
153-
154140
const panelBackdropClasses: string = mergeClasses([
155141
styles.panelBackdrop,
156142
panelWrapperClassNames,

src/components/Panel/Panel.types.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@ export type PanelPlacement = 'top' | 'right' | 'bottom' | 'left';
1919

2020
export type EventType =
2121
| React.KeyboardEvent<HTMLDivElement>
22-
| React.MouseEvent<HTMLDivElement | HTMLButtonElement>
23-
| KeyboardEvent;
22+
| React.MouseEvent<HTMLDivElement | HTMLButtonElement>;
2423

2524
export type CloseButtonProps = Omit<ButtonProps, 'onClick' | 'iconProps'>;
2625

0 commit comments

Comments
 (0)