Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display HTML content rather than just text content #35

Open
EdwardHinkle opened this issue Mar 15, 2018 · 1 comment
Open

Display HTML content rather than just text content #35

EdwardHinkle opened this issue Mar 15, 2018 · 1 comment

Comments

@EdwardHinkle
Copy link
Owner

Currently the timeline view only displays text content from a post, not html content. This is because a label is used to display the text. (this could also potentially help fix parts of #89)

There are a couple directions we could go with this.

My first attempt was to try embedding WKWebView in each post view, and pass the Content HTML in as an HTML string, however that seems to take awhile to load and it's ugly and has issues with it being a scroll view, etc. There may be some better approaches while still using that but I think I've decided to sideline that for awhile.

Another approach is to implement #89 to get images out of the html content, and then convert the HTML content into Attributed Text.
Some links to think through:
https://stackoverflow.com/questions/28124119/convert-html-to-plain-text-in-swift
https://medium.com/theappspace/swift-how-to-convert-html-using-nsattributedstring-8c6ffeb7046f

Besides those, I'm thinking the other option is to only show text content on the timeline view and show HTML on the Full Article view when you swipe right to left.

@EdwardHinkle EdwardHinkle self-assigned this Mar 15, 2018
@EdwardHinkle EdwardHinkle removed their assignment Jul 3, 2018
@EdwardHinkle
Copy link
Owner Author

Currently, I have gone with the Text content in Timeline View and HTML in Full Post View. I'd like to improve this in the future, but there are higher priority issues right now

@EdwardHinkle EdwardHinkle transferred this issue from IndiePass/indiepass-ios May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant