Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it really parabolic interpolation ? #3

Open
scarpma opened this issue May 10, 2023 · 1 comment
Open

Is it really parabolic interpolation ? #3

scarpma opened this issue May 10, 2023 · 1 comment

Comments

@scarpma
Copy link

scarpma commented May 10, 2023

Hello,
thanks for sharing this beautiful work. I have a soubt about the parabolic wss computation. At line

https://github.com/EdwardFerdian/wss_mri_calculator/blob/e206a83ccd91833436f1fad27f520678fced77d0/src/calculate_wss.py#LL101C17-L101C35

you perform the "sampling" of the velocity at specific points inside the domain, which do not coincide with voxel centers. This involves an interpolation that I think is linear (but i am not sure as I could't find details in the pyvista documentation), so the overall interpolation procedure would give results that are not parabolic.

If I understood well in this paper, you should pick the velocity values at voxel centers that are nearest to the locations of the surface wall, without interpolating them. At that point, you will perform the parabolic interpolation.

Am I wrong ?

@EdwardFerdian
Copy link
Owner

EdwardFerdian commented May 12, 2023

If I remember correctly, PyVista is using linear interpolation by default during sampling.

I have not touch this for a while, and you are probably right about the method. Feel free to suggest any correction or any work around :)
Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants