Tweak colors #4709
Merged
Tweak colors #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paullinator
force-pushed
the
paul/tweakBlur
branch
7 times, most recently
from
ee06c86 to
a76798d
Compare
|
paullinator
force-pushed
the
paul/tweakBlur
branch
from
a76798d to
0df3050
Compare
Jon-edge
requested changes
Jan 15, 2024
There was a problem hiding this comment.
Remove Ui4 from keys
https://app.asana.com/0/1200382638405084/1206315466361658/f
There was a problem hiding this comment.
I noticed discrepancies between Android and iOS screens. Can we add cases to make it consistent? I noticed that only thing here specific to Android is the BlurView's overlayColor, and we can probably make it look more consistent if we case out modalBackgroundUi4 to be darker or more transparent on Android
Jon-edge
approved these changes
Jan 15, 2024
ts-expect-error was hiding errors
This ensures every theme has the parameters even if disabled
Per live discussion with design, these were the decided color values
Remove extra LinearGradientA llow separate iOS gradient colors to compensate for blurview darkening/lightening
paullinator
force-pushed
the
paul/tweakBlur
branch
from
0df3050 to
be45047
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: