Add scroll-based animation to HeaderBackground #4706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this tested on iOS and Android? |
Yes, it's tested on both iOS and Android. I haven't tested on tablet or small screen admittedly . |
swansontec
approved these changes
Jan 12, 2024
src/state/SceneScrollState.tsx
Outdated
| sceneScrollContext.scrollMomentumEndEvent.value = nativeEvent | ||
| } | ||
| }) | ||
| [] |
There was a problem hiding this comment.
This gets removed again 2 commits later. Was that a mistake?
| opacity: 0 | ||
| }, | ||
| useAnimatedStyle(() => ({ | ||
| opacity: interpolate(scrollY.value, [0, MAX_TAB_BAR_HEIGHT], [0, 1]) |
There was a problem hiding this comment.
Optional: MAX_TAB_BAR_HEIGHT might be the wrong constant to use in the header. Do we have a header height constant somewhere?
I hope this means we have static handlers and don't thrash the event handlers unnecessarily, but who knows really what is going on behind the scenes with reanimated since they'll probably do fancy optimizations and tricks that aren't react-kosher (I've seen things).
This required a significant refactor and improvement to global scroll state handling for each scene and component which uses the `useSceneScrollHandler` hook.
samholmes
force-pushed
the
sam/dynamic-header
branch
from
c1aad19 to
d1e63d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: