Jon/fix/experiment-config-init #4543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samholmes
requested changes
Oct 23, 2023
Jon-edge
force-pushed
the
jon/fix/experiment-config-init
branch
from
802a037 to
dd582a1
Compare
samholmes
requested changes
Oct 24, 2023
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| - added: Paybis sell to debit card | |||
| - changed: Change FlipInput styling to make the edit functionality more obvious | |||
| - changed: Move asset-specific settings into their own settings page | |||
| - fixed: Experiment config generation for more than 2 variants | |||
There was a problem hiding this comment.
fixed: Write updated experiment configs to disk and changed: Experiment config probability distribution support percentage based values
src/experimentConfig.ts
Outdated
| console.error(`Misconfigured experimentDistribution for: '${key}'`) | ||
| } else { | ||
| // Distribute the probability of each config value | ||
| const totalProbability = variantProbability.reduce((sum, probability) => sum + probability, 0) |
There was a problem hiding this comment.
I don't think this value is a "probability" but instead a denomination, so that might be a better name because that's what it is for each probability we calculate.
There was a problem hiding this comment.
I assume you are referring only to variantDenomination because total denomination makes no sense
src/experimentConfig.ts
Outdated
| if (totalProbability > 101 || totalProbability < 99) { | ||
| console.warn(`Config values for ${key} do not add up to 100% +/- 1%`) | ||
| } | ||
| const distributedProbabilities = variantProbability.map(probability => probability / totalProbability) |
There was a problem hiding this comment.
Division by zero isn't handled when it should.
Jon-edge
force-pushed
the
jon/fix/experiment-config-init
branch
from
dd582a1 to
c273f30
Compare
samholmes
force-pushed
the
jon/fix/experiment-config-init
branch
from
c273f30 to
bebe736
Compare
samholmes
approved these changes
Oct 25, 2023
samholmes
force-pushed
the
jon/fix/experiment-config-init
branch
from
bebe736 to
6dab471
Compare
|
/rebase |
The logic was incorrect for checking each bucket of probabilities for 3+ variants
If new values were added to the experiment config, those new values weren't getting stored and the client was regenerating every time
github-actions
bot
force-pushed
the
jon/fix/experiment-config-init
branch
from
6dab471 to
ad8fdb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have: