diff --git a/CHANGELOG.md b/CHANGELOG.md index fa167d9f..460dd38c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ ## Unreleased +- fixed: Check for NaN target totals in `subtractFee` style transactions + ## 2.5.3 (2024-01-24) - changed: Add insufficient funds check `subtractFee` style transactions diff --git a/src/common/utxobased/keymanager/utxopicker/subtractFee.ts b/src/common/utxobased/keymanager/utxopicker/subtractFee.ts index 207dbafb..87f38042 100644 --- a/src/common/utxobased/keymanager/utxopicker/subtractFee.ts +++ b/src/common/utxobased/keymanager/utxopicker/subtractFee.ts @@ -15,7 +15,8 @@ export function subtractFee(args: UtxoPickerArgs): UtxoPickerResult { outputs[0].value -= fee const targetValue = utils.sumOrNaN(targets) - if (fee > targetValue) return { inputs: utxos, fee, changeUsed: false } + if (isNaN(targetValue) || fee > targetValue) + return { inputs: utxos, fee, changeUsed: false } return { inputs: utxos, outputs, fee, changeUsed: false } }