Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enabling a custom token without adding token info #253

Open
wolverineks opened this issue Feb 15, 2021 · 2 comments
Open

enabling a custom token without adding token info #253

wolverineks opened this issue Feb 15, 2021 · 2 comments

Comments

@wolverineks
Copy link
Contributor

it looks like enabling a token assumes that the token info is already included or has already been added
this could lead to a state where a currency code is "enabled" but not really enabled

or am i missing something?
@wolverineks
Copy link
Contributor Author

i imagine it shouldn't save custom token currency codes to disk,
and it shouldnt enable a currency code if there isnt a corresponding EdgeMetaToken in the currency info or provided by wallet.addCustomToken()

@wolverineks
Copy link
Contributor Author

If tokens are supposed to be synced, then they shouldn't be saved in walletLocalData

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wolverineks