Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on two areas of the codebase: the
SubscriptionsSearchRequest
data class and the metrics-related files in thecom.ecwid.apiclient.v3.metric
package. The changes in theSubscriptionsSearchRequest
data class simplify the code by always setting theoffset
andlimit
parameters. The metrics-related files have been updated to use theio.prometheus.metrics.core.metrics
package instead of theio.prometheus.client
package, and several methods and parameters have been renamed or added to align with the new package's conventions.Changes to
SubscriptionsSearchRequest
data class:src/main/kotlin/com/ecwid/apiclient/v3/dto/subscriptions/request/SubscriptionsSearchRequest.kt
: Theoffset
andlimit
parameters are now always set, regardless of whether they have a value or not.Changes to metrics-related files:
src/main/kotlin/com/ecwid/apiclient/v3/metric/RequestRetrySleepMetric.kt
: TheCounter
import has been changed fromio.prometheus.client.Counter
toio.prometheus.metrics.core.metrics.Counter
, and themetric
object has been updated to use theCounter.builder()
method.src/main/kotlin/com/ecwid/apiclient/v3/metric/RequestSizeMetric.kt
: TheHistogram
import has been changed fromio.prometheus.client.Histogram
toio.prometheus.metrics.core.metrics.Histogram
, and themetric
object has been updated to use theHistogram.builder()
method. Thelabels()
method has been replaced with thelabelValues()
method. [1] [2] [3]src/main/kotlin/com/ecwid/apiclient/v3/metric/RequestTimeMetric.kt
: TheHistogram
import has been changed fromio.prometheus.client.Histogram
toio.prometheus.metrics.core.metrics.Histogram
, and themetric
object has been updated to use theHistogram.builder()
method. Thelabels()
method has been replaced with thelabelValues()
method. [1] [2]src/main/kotlin/com/ecwid/apiclient/v3/metric/ResponseSizeMetric.kt
: TheHistogram
import has been changed fromio.prometheus.client.Histogram
toio.prometheus.metrics.core.metrics.Histogram
, and themetric
object has been updated to use theHistogram.builder()
method. Thelabels()
method has been replaced with thelabelValues()
method. [1] [2] [3]