Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus lib to 1.1 #390

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Update prometheus lib to 1.1 #390

merged 3 commits into from
Mar 21, 2024

Conversation

turchenkoalex
Copy link
Contributor

This pull request primarily focuses on two areas of the codebase: the SubscriptionsSearchRequest data class and the metrics-related files in the com.ecwid.apiclient.v3.metric package. The changes in the SubscriptionsSearchRequest data class simplify the code by always setting the offset and limit parameters. The metrics-related files have been updated to use the io.prometheus.metrics.core.metrics package instead of the io.prometheus.client package, and several methods and parameters have been renamed or added to align with the new package's conventions.

Changes to SubscriptionsSearchRequest data class:

Changes to metrics-related files:

@turchenkoalex turchenkoalex self-assigned this Mar 21, 2024
@Alexis2004 Alexis2004 merged commit 495cc1b into master Mar 21, 2024
2 checks passed
@turchenkoalex turchenkoalex deleted the ECWID-133682 branch March 21, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants