Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prometheus to 1.1 #14

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Update prometheus to 1.1 #14

merged 3 commits into from
Apr 19, 2024

Conversation

turchenkoalex
Copy link
Contributor

@turchenkoalex turchenkoalex commented Feb 23, 2024

This pull request includes changes to the PrometheusMetrics.kt file in the src/main/kotlin/com/ecwid/clickhouse/metrics directory. The changes are focused on modifying the import statements and the methods used for metrics collection.

Key changes include:

  • src/main/kotlin/com/ecwid/clickhouse/metrics/PrometheusMetrics.kt: The import statements for Counter and Summary have been updated to use io.prometheus.metrics.core.metrics.Counter and io.prometheus.metrics.core.metrics.Summary respectively. The methods startRequestTimer and measureRequest have been updated to use labelValues instead of labels. The requestsLatencySummary and requestsCounter objects have been updated to use the builder method and their names have been updated to include the subsystem name.

@turchenkoalex turchenkoalex self-assigned this Mar 20, 2024
@turchenkoalex turchenkoalex force-pushed the update-prometheus-1.0 branch from a478ca7 to 69bbb54 Compare March 20, 2024 11:10
@turchenkoalex turchenkoalex marked this pull request as ready for review March 20, 2024 11:10
@turchenkoalex turchenkoalex requested a review from vgv March 20, 2024 11:10
@turchenkoalex turchenkoalex marked this pull request as draft March 20, 2024 11:32
@turchenkoalex turchenkoalex marked this pull request as ready for review March 20, 2024 11:34
@turchenkoalex turchenkoalex force-pushed the update-prometheus-1.0 branch from 6058edd to eab334c Compare April 2, 2024 06:42
@vgv vgv merged commit 8432f14 into master Apr 19, 2024
1 check passed
@vgv vgv deleted the update-prometheus-1.0 branch April 19, 2024 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants