You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The main idea is to return the cause of a query non-error-failure over GRPC so that we can display the information to users in the GUI instead of printing it to the console.
This involves first changing the query.proto to include a cause message when a check fails and secondly to update the verification checks in the code to return causes when checks fail
I propose introducing enums (or structs) for verification checks equivalent to the messages in the protos.
Fx. change the refinement check return type such that we can never return Ok(false) in the refinement check but instead must return an enum:
The failure should then contain much of what we already print in the code e.g. Failure(format!("Refinement check failed for Output {:?} from location pair {:?}", ...)) and Failure(format!("Refinement check because {:?} is not consistent", ...)).
The text was updated successfully, but these errors were encountered:
The main idea is to return the cause of a query non-error-failure over GRPC so that we can display the information to users in the GUI instead of printing it to the console.
This involves first changing the query.proto to include a cause message when a check fails and secondly to update the verification checks in the code to return causes when checks fail
Changing query proto
The current message:
Should become something like:
Changing verification checks
I propose introducing enums (or structs) for verification checks equivalent to the messages in the protos.
Fx. change the refinement check return type such that we can never return
Ok(false)
in the refinement check but instead must return an enum:The failure should then contain much of what we already print in the code e.g.
Failure(format!("Refinement check failed for Output {:?} from location pair {:?}", ...))
andFailure(format!("Refinement check because {:?} is not consistent", ...))
.The text was updated successfully, but these errors were encountered: